Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas limit fix for RSK chain #290

Merged
merged 11 commits into from
Jun 12, 2019
Merged

gas limit fix for RSK chain #290

merged 11 commits into from
Jun 12, 2019

Conversation

vbaranov
Copy link
Collaborator

Build on top of #289

For simple coin transfer gas limit was calculated incorrectly.
Missing code === '0x0 added to check if this simple coin transfer or not.

@vbaranov vbaranov requested a review from patitonar June 11, 2019 15:00
This was referenced Jun 11, 2019
Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov any idea why ci/circleci: test-e2e-chrome is failing?

Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Once errors from ci/circleci: test-e2e-chrome are fixed, we can merge this

@vbaranov
Copy link
Collaborator Author

I removed blinking tests.

@vbaranov vbaranov merged commit e1fa42b into develop Jun 12, 2019
@vbaranov vbaranov deleted the rsk-gaslimit-fix branch June 12, 2019 12:45
@vbaranov vbaranov mentioned this pull request Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants